What's the reason to no longer sync the version numbers between build.sbt and plugins.sbt?

@SethTisue

The following link opens: https://repo.maven.apache.org/maven2/com/github/os72/protoc-jar/3.11.4/

But not the following: https://repo.maven.apache.org/maven2/com/github/os72/protoc-jar/3.24.4/

So I thought there might be no matching protoc-jar version, therefore I removed the sync.

I don't really understand this stuff, but 3.11.4 is also the latest at https://github.com/os72/protoc-jar and the readme there says

Supports embedded protoc versions 2.4.1, 2.5.0, 2.6.1, 3.11.4, and any protoc version available for download from maven central

so I guess it's okay?

in local testing (on my M2 Mac), I see this when I bin/run-ci.sh

protoc-jar: protoc version: 3.24.4, detected platform: osx-aarch_64 (mac os x/aarch64)
...
protoc-jar: executing: [/var/folders/8k/dr4fq5yj3pq9tb1l86ykt17m0000gn/T/protocjar10628966791626407979/bin/protoc.exe, -I/Users/tisue/zinc/internal/zinc-persist-core/src/main/protobuf, -I/Users/tisue/zinc/internal/zinc-persist-core/target/protobuf_external, --java_out=/Users/tisue/zinc/internal/zinc-persist-core/target/src_managed/main/compiled_protobuf, /Users/tisue/zinc/internal/zinc-persist-core/src/main/protobuf/schema.proto, /Users/tisue/zinc/internal/zinc-persist-core/src/main/protobuf/zprof.proto]

and sbt -v -Dfile.encoding=UTF-8 -Dsbt.supershell=never "crossTestBridges" "zincRoot/test" "zincScripted/Test/run" also succeeds, so everything seems good, afaict!

can you sign the Scala CLA?

can you sign the Scala CLA?

Yes. Just finished signing the CLA:

https://www.lightbend.com/contribute/cla/scala/check/Friendseeker
{"user":"Friendseeker","signed":true,"version":"1.0","currentVersion":"1.0"}

Thank you for your swift review!

Thank you for the PR... always nice when we can remove build cruft